Partial revert of 78b5f00, to fix webview black screen #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelson42
force-pushed
the
818-under-certain-condition-opening-zim-homepage-gives-a-black-screen
branch
from
e71f5be to
de47745
Compare
|
I can really not judge the nature of the patch. It womders me that we need a "hack" but I will merge and if it works this is the most important. |
kelson42
deleted the
818-under-certain-condition-opening-zim-homepage-gives-a-black-screen
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #818
After many experiments I haven't found anything useful, as the UI layer was crashing, and XCode could not debug it anymore...
So I investigated with earlier versions of the app, and after some git bisect it turned out that the commit 78b5f00 was the one to blame.
I still think it is not ideal, in terms of the code, but at the moment this is the very best version, that has no side effects.
I have tested it on all devices, and seems to work as expected.