Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom js #824

Closed
wants to merge 8 commits into from
Closed

Conversation

BPerlakiH
Copy link
Collaborator

Fixes: #816

As a matter of fact the base PR is fixing the real issue:
#823

since we are on this, it's better to fix the custom JS code as well.

rgaudin
rgaudin previously approved these changes Jun 21, 2024
Copy link
Member

@rgaudin rgaudin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ; please rename commit so we don't loose the why we've added this

Base automatically changed from 815-zim-is-not-vertically-alligned-properly to main June 21, 2024 13:38
@kelson42 kelson42 dismissed rgaudin’s stale review June 21, 2024 13:38

The base branch was changed.

@kelson42 kelson42 force-pushed the 816-losing-capacity-to-focus-in-a-zim branch from da38b9f to a542436 Compare June 21, 2024 13:40
@BPerlakiH
Copy link
Collaborator Author

Replaced with: #825

@BPerlakiH BPerlakiH closed this Jun 22, 2024
@BPerlakiH BPerlakiH linked an issue Jun 22, 2024 that may be closed by this pull request
@BPerlakiH BPerlakiH deleted the 816-losing-capacity-to-focus-in-a-zim branch February 19, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Losing capacity to focus in a ZIM
3 participants