Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tappable to check if UIControl is enabled #1250

Merged
merged 1 commit into from
Dec 13, 2021
Merged

Update tappable to check if UIControl is enabled #1250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 29 additions & 1 deletion Sources/KIF/Additions/UIView-KIFAdditions.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,35 @@ - (BOOL)isProbablyTappable
// Is this view currently on screen?
- (BOOL)isTappable;
{
return [self isTappableInRect:self.bounds];
return ([self hasTapGestureRecognizerAndIsControlEnabled] ||
[self isTappableInRect:self.bounds]);
}

- (BOOL)hasTapGestureRecognizerAndIsControlEnabled
{
__block BOOL hasTapGestureRecognizer = NO;

[self.gestureRecognizers enumerateObjectsUsingBlock:^(id obj,
NSUInteger idx,
BOOL *stop) {
if ([obj isKindOfClass:[UITapGestureRecognizer class]]) {
hasTapGestureRecognizer = YES;

if (stop != NULL) {
*stop = YES;
}
}
}];

// In iOS 15 UIButton's still have tap gesture recognizers when disabled.
// This prevents a control that is disabled, but still has the system gesture
// recognizers to say it's tappable.
if ([self isKindOfClass:[UIControl class]]) {
UIControl *control = (UIControl *)self;
return hasTapGestureRecognizer && control.isEnabled;
}

return hasTapGestureRecognizer;
}

- (BOOL)isTappableInRect:(CGRect)rect;
Expand Down