Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Xcode 11 (Beta) build error (implicit conversion warning) #1111

Merged
merged 2 commits into from
Jun 7, 2019
Merged

Fix Xcode 11 (Beta) build error (implicit conversion warning) #1111

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6d4819f
Fix Xcode 11 build error (implicit conversion warning)
Jun 5, 2019
1b466d5
Use boxed expression instead of typecasting
justinseanmartin Jun 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Classes/KIFSystemTestActor.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ - (void)simulateMemoryWarning

- (void)simulateDeviceRotationToOrientation:(UIDeviceOrientation)orientation
{
[[UIDevice currentDevice] setValue:[NSNumber numberWithInt:orientation] forKey:@"orientation"];
[[UIDevice currentDevice] setValue:[NSNumber numberWithInt:(int)orientation] forKey:@"orientation"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could just use @(orientation) and avoid the explicit cast. That'd be cleaner if it works IMO.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it locally and it fixes the compiler error. Went ahead and made that change in this branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, definitely cleaner. Thanks for the fast follow up!

}


Expand Down