Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert backend to use Tapir #23

Merged
merged 13 commits into from
Sep 10, 2022
Merged

Convert backend to use Tapir #23

merged 13 commits into from
Sep 10, 2022

Conversation

lolgab
Copy link
Contributor

@lolgab lolgab commented Sep 8, 2022

Endpoints are now defined using tapir in a shared module between
backend and frontend. For now, the frontend wasn't updated to make
good use of these endpoints yet

Endpoints are now defined using tapir in a shared module between
backend and frontend. For now the frontend wasn't update to make
good use of these endpoints yet
@lolgab lolgab changed the title Tapir Convert backend to use Tapir Sep 8, 2022
@keynmol
Copy link
Owner

keynmol commented Sep 8, 2022

This is currently blocked by softwaremill/sttp-model#218
Once that's release, theoretically just adding libdn2 to vcpkg dependencies should be enough

@keynmol
Copy link
Owner

keynmol commented Sep 9, 2022

Before the full tapir release I believe you can test it by modifying the dependencies in the app module:

      vcpkgDependencies := Set("libpq", "openssl", "libidn2"),
      libraryDependencies += "com.softwaremill.sttp.model" %%% "core" % "1.5.2",

@mergify mergify bot mentioned this pull request Sep 10, 2022
@lolgab lolgab marked this pull request as ready for review September 10, 2022 08:42
Copy link
Owner

@keynmol keynmol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the virtue of not having any meaningful tests, I declare this to be perfect.

@keynmol keynmol merged commit c6bbc5a into keynmol:main Sep 10, 2022
@lolgab lolgab deleted the tapir branch September 10, 2022 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants