Fcc detector migration

[atolosadelgado]

BEGINRELEASENOTES

• Migration of IDEA and ALLEGRO detectors from FCCDetectors repository, becoming each one the option 1 version 01 of the corresponding detector
  • The compact files and detector constructors files, and the detector name therein, are renamed to avoid collision with FCCDetector components by appending the suffix _o1_v01
  • IDEA compact files are copied into ./FCCee/IDEA/compact/IDEA_o1_v01
  • ALLEGRO compact files are copied into ./FCCee/ALLEGRO/compact/ALLEGRO_o1_v01
  • The detector constructors are placed in the corresponding directory inside ./detector, and therein in the appropriate sub-directory;
    • calorimeter: CaloEndcapDiscs_o1_v01_geo.cpp, HCalThreePartsEndcap_o1_v01_geo.cpp, HCalTileBarrel_o1_v01_geo.cpp
    • other: SimpleCylinder_geo_o1_v01.cpp
    • tracker: parametrised_DriftChamber_o1_v01.cpp
  • DD4hep segmentations from FCCDetectors were also migrated into the directory detectorSegmentations, and renamed by appending the suffix _k4geo

ENDRELEASENOTES

Hi all,

this PR implements the changes stated here
#267 (comment)

this PR is not ready yet, and some things are open to discussion. Particularly, how to handle the non-detector parts migrated from FCC detector repo. At the moment they are placed in detector/{DetSegmentation, DetCommon, DetSensitive}

DetCommon defines a number of global functions that are needed mainly to reconstruction. Only the function cellID implemented in DetCommon is used in FCCDetectors by DetSensitive.

Thank you for your time.
Alvaro

[andresailer]

As discussed in the Key4hep meeting, it would be better to remove things that are not needed, for example in the DetCommon folder.

[BrieucF]

Breaking news: you can change NLB to ALLEGRO !

[atolosadelgado]

Hi,

I purged some files out of DetCommon. I kept for testing purposes a simple box dummy detector. The simple box was used to test the Sensitive Detector actions, but actually the cmake test command is now commented. I still think a test is healthy for the repo, but since this PR is urgent I did not spend time on rewriting the test.

I moved the segmentation and senstive detector folders to main folder and renamed according to the proposal in #267

a test Gaudi simulation was run to check if the changes were consistent.

Renaming of the segmentation and sensitive detectors is still ongoing

[atolosadelgado]

Hi,

as discussed in the key4hep meeting, i have removed the DetCommon and sensitive detectors folder. The segmentation classes have been renamed, adding _k4geo to the name.

The detectors from FCCDetectors repo are also migrated, xml and cpp files. The name is also changed so they will not clash.

I hope there are not many issues... I changed a lot of code

Alvaro

[BrieucF]

Any further comment on this @andresailer ?

[atolosadelgado]

I think I have documented the corresponding READMEs
I still do not know what to do with the dependency of the drift chamber on segmentation library.

[atolosadelgado]

Should some release note comments be filled in the OP?

[andresailer]

Should some release note comments be filled in the OP?

Yes, definitely! Thanks!

[atolosadelgado]

Hi,

I have displayed the geometries of IDEA and ALLEGRO with geoDisplay tool, it worked. No warnings during compilation.

I found that for some reason the Drift chamber and calorimeter of IDEA were commented out from the main file, but now they are ready.

Anyway, these components were templates for the future ones, some of them already in PR or upcoming soon.

I can not think of further refinements, but please let me know if I can do something else.

Tests for the new detectors will be part of an upcoming PR