Switch to dd4hep::CellID for compatibility with dd4hep #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmadlener
changed the title
|
@jmcarcell It seems the key4hep based CI workflows are failing due to some missing libraries. On the other hand, the one based on the CLIC nightlies are OK, and they are building against the latest dd4hep where these changes are necessary to even build. Since the CLIC nightlies will stop working without these changes, I would be in favor of merging this quickly, unless you already have a fix in mind for the key4hep builds. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
dd4hep::CellIDfor cellIDs, after AIDASoft/DD4hep#1125ENDRELEASENOTES
@andresailer To make this slightly less brittle, I would need a new DD4hep tag, so that I can put in some pre-processor conditions.Actually scratch that, theCellIDtypedef exists in older versions as well, so this should be transparent.