New bfield map and Guinea-Pig reader

[luisaleperez]

Added a couple of new functionality still under development

• New B-field map
• Guinea-Pig reader

[andresailer]

The event reader is not a sensitive detector.
Maybe create a plugins folder?

[andresailer]

This is "work in progress", so it is not expected to get merged until development is complete, right?

[gaede]

• You are right, creating a folder 'plugins' would be cleaner for the Geant4EventReader. However we eventually want to move this to DD4hep, once it is well tested and proven to work. It is just simpler to develop it in lcgeo for the time being.

• I would like to include this in the master, event though it is not fully tested, just to have it in the development stream and the nightlies, etc...

• one issue that we still have is the primary vertex of the pair particles, which seems to be ignored in ddsim/DDG4. I remember that we discussed this before for non-prompt single particles from the gun but do not remember what the resolution was.
  How do we get DDG4/ddsim to take the individual MCParticle's start vertex as G4PrimaryVertex ?

[andresailer]

• Why not directly develop the GuineaPig reader it in DD4hep then?

• I don't think we should merge code that is not completely developed. Right now there is no difference between FieldMapXYZ and FieldMapBrBz besides the name of the class.

• What exactly do you mean by "non-prompt single particles from the gun"? And why not open an issue in DD4hep about multiple vertex positions for individual events, so we can discuss it there.

[gaede]

Why not directly develop the GuineaPig reader it in DD4hep then?

• see my previous comment

I don't think we should merge code that is not completely developed. Right now there is no difference between FieldMapXYZ and FieldMapBrBz besides the name of the class.

• Since when have we adopted this policy ? We always committed partly incomplete code to the trunk/HEAD - as long as it compiled and it did not interfere with the rest of the code.

What exactly do you mean by "non-prompt single particles from the gun"? And why not open an issue in DD4hep about multiple vertex positions for individual events, so we can discuss it there.

• Seems that you also don't remember what we discussed a while ago in one of the DD4hep developers meeting. Will come back to the issue when we know more ...

[petricm]

The GuineaPig reader is broken with respect to the DD4hep head. Please fix it. It would also be appreciated if it could be moved to DD4hep as it's tightly linked with it and to avoid such situations.

[gaede]

Sorry, got interrupted when making the PR - here it is: #33

[luisaleperez]

Hello Frank, I don't understand, do I have to do something or di you aready fixed it? Any news about the vertex positions for the primaries? Many thanks, Aleandro

…

On 02/13/2017 06:28 PM, Frank Gaede wrote: Sorry, got interrupted when making the PR - here it is: #33 <#33> — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#15 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AYDhmqkV7VR3iEDpim0cahE9G6oMn-PZks5rcJK4gaJpZM4LpLNY>.

-- -------------------------------------------------------------------------------------- | Luis Alejandro PÉREZ PÉREZ | | CRNS - Institut Pluridisciplinaire Hubert Curien (IPHC) | | Dept. de Recherches Subatomiques phone : +33 (0)3 88 10 68 04 | | 23, rue du loess - BP 28 fax : +33 (0)3 88 10 62 34 | | F-67037- STRASBOURG cedex 2 e-mail : Luis_Alejandro.Perez_Perez@iphc.cnrs.fr | --------------------------------------------------------------------------------------