upgraded fineuploader plugin to use cdnjs by default so it no longer … #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…requires installation, make template configurable
|
@brentkelly I definitely think its worth it and should exist as a subtype. If a dev wants it to be the default they can either use combination of |
|
OK cool - I'll rework this PR & let you know when it's good to go. |
…f file. Make `type`:`file` support `subtype`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…requires installation, make template configurable
Thanks @rnicholus for pointing out the CDN.
@kevinchappell - one thing you may want to consider now that it doesn't require installation & 'just works', is if it is worth including this in the core set of controls - either as the default
file uploadercontrol, or possibly in thesubtypedropdown forfile uploader.Alternatively can just leave it as a plugin - which would make sense if a lot of the users wouldn't use this functionality.
Guess it depends how lightweight you are trying to keep the project out of the box.