Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for bug in numberAttribute method where min, max and step are passed on as attributes instead of as value #1018

Merged
merged 1 commit into from
Dec 31, 2019
Merged

Fix for bug in numberAttribute method where min, max and step are passed on as attributes instead of as value #1018

merged 1 commit into from
Dec 31, 2019

Conversation

nahojd
Copy link
Contributor

@nahojd nahojd commented Dec 30, 2019

This is a fix for the issue in #999

@nahojd nahojd mentioned this pull request Dec 30, 2019
Closed
@kevinchappell
Copy link
Owner

kevinchappell commented Dec 31, 2019 •
edited
Loading

min, max and step are intentionally attributes https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/number#max

Can you share a codesandbox or jsfiddle of the expected result?

ok im up to speed on the issue. going to test now

@kevinchappell
Copy link
Owner

looks good. 👍

@kevinchappell kevinchappell merged commit 032949b into kevinchappell:master Dec 31, 2019
@kevinchappell
Copy link
Owner

🎉 This PR is included in version 3.2.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kevinchappell kevinchappell mentioned this pull request May 28, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nahojd @kevinchappell