fix: formData may contain HTML (eg Labels), need to escape for all da…

…taTypes before adding into the code element. JSON is invalid if copy-paste from showData dialog
kevinchappell · Oct 5, 2023 · c6f89d1 · c6f89d1
1 parent 843eca7
commit c6f89d1
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/src/js/helpers.js b/src/js/helpers.js
@@ -988,11 +988,7 @@ export default class Helpers {
    * Open a dialog with the form's data
    */
   showData() {
-    let formData = this.getFormData(config.opts.dataType, true)
-
-    if (config.opts.dataType === 'xml') {
-      formData = escapeHtml(formData)
-    }
+    const formData = escapeHtml(this.getFormData(config.opts.dataType, true))
 
     const code = m('code', formData, {
       className: `formData-${config.opts.dataType}`,