Skip to content

Commit

Permalink
Fix semantics bug detected by clang++-20
Browse files Browse the repository at this point in the history
Also removed redundant template.
  • Loading branch information
keryell committed Oct 21, 2024
1 parent bdabd50 commit 6d57ffc
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
4 changes: 2 additions & 2 deletions include/triSYCL/vendor/Xilinx/acap/aie/hardware.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -307,9 +307,9 @@ struct dev_ptr {
dev_ptr operator-(std::ptrdiff_t off) { return {add(ptr, -off)}; }
std::ptrdiff_t operator-(dev_ptr other) { return ptr - other.ptr; }
dev_ptr& operator++() { ptr = add(ptr, 1); return *this; }
dev_ptr operator++(int) { dev_ptr old = *this; *this++; return old; }
dev_ptr operator++(int) { dev_ptr old = *this; (*this)++; return old; }
dev_ptr& operator--() { ptr = add(ptr, -1); return *this; }
dev_ptr operator--(int) { dev_ptr old = *this; *this--; return old; }
dev_ptr operator--(int) { dev_ptr old = *this; (*this)--; return old; }

/// Pointer comparaison
bool operator==(dev_ptr other) const { return ptr == other.ptr; }
Expand Down
6 changes: 2 additions & 4 deletions tests/acap/cascade_pipeliner.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@
#include <sycl/sycl.hpp>

#include <iostream>
#include <tuple>
#include <type_traits>
#include <utility>

#include <boost/hana.hpp>
Expand Down Expand Up @@ -99,11 +97,11 @@ struct cascade_executor {

auto get_executor() {
// AIE NoC connection between shim and input of the pipeline
d.template connect(port::shim { 0, 0 }, port::tile { 0, 0, 0 });
d.connect(port::shim { 0, 0 }, port::tile { 0, 0, 0 });
// AIE NoC connection between output of the pipeline and the shim
auto last_x = decltype(d)::geo::cascade_linear_x(last_stage);
auto last_y = decltype(d)::geo::cascade_linear_y(last_stage);
d.template connect(port::tile { last_x, last_y, 0 },
d.connect(port::tile { last_x, last_y, 0 },
port::shim { 1, 0 });
return [&] (FirstT input) {
d.shim(0).bli_out(0) << input;
Expand Down

0 comments on commit 6d57ffc

Please sign in to comment.