Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add the possibility to close trades at end of bt.run (#273 & #343) #393

Merged
merged 7 commits into from
Jan 30, 2025
Merged

ENH: Add the possibility to close trades at end of bt.run (#273 & #343) #393

merged 7 commits into from
Jan 30, 2025

Conversation

Benouare
Copy link
Contributor

@Benouare Benouare commented Jun 21, 2021 •
edited by kernc
Loading

Fixes #343
Closes #1102
Fixes #1201

@kernc kernc mentioned this pull request Jun 22, 2021
Closed
@Benouare Benouare force-pushed the feature/fix_auto_close branch from 60f5cfb to 4f8dcc7 Compare June 23, 2021 07:50
@Benouare Benouare force-pushed the feature/fix_auto_close branch from 4f8dcc7 to 3971535 Compare June 23, 2021 08:50
@mdavidg
Copy link

mdavidg commented Aug 17, 2021

Please solve conflicts in order to get this changes merged in master! @kernc @Benouare

@Benouare
Copy link
Contributor Author

Benouare commented Sep 2, 2021

@kernc Up ;)

@kernc kernc force-pushed the master branch 3 times, most recently from 7fd493d to e7981c7 Compare December 13, 2021 01:18
@souresia
Copy link

This would also solve #535

@kernc kernc force-pushed the master branch 9 times, most recently from 60eff81 to 109c352 Compare November 28, 2022 22:33
@kernc kernc force-pushed the master branch 5 times, most recently from 428c361 to 0ce6cab Compare January 21, 2025 07:25
@kernc kernc self-assigned this Jan 21, 2025
@kernc kernc force-pushed the feature/fix_auto_close branch from fba66a0 to d0f7ee3 Compare January 30, 2025 05:32
@kernc kernc force-pushed the feature/fix_auto_close branch from d0f7ee3 to 3450455 Compare January 30, 2025 05:34
@kernc kernc merged commit ae3d69f into kernc:master Jan 30, 2025
4 checks passed
@kernc kernc mentioned this pull request Feb 2, 2025
Closed
mmortall pushed a commit to mmortall/backtesting-ext.py that referenced this pull request Feb 3, 2025
@Benouare @pr0kium @kernc
ENH: Optionally finalize trades at the end of backtest run (kernc#393)
76d19df 
* ENH: Add the possibility to close trades at end of bt.run (kernc#273 & kernc#343)

* Change parameter name, simplify tests
* Fix failing test

---------

Co-authored-by: Bénouare <le.code.43@gmail.com>
Co-authored-by: benoit <flood@benoit-laviale.fr>
Co-authored-by: Kernc <kerncece@gmail.com>
@kernc kernc mentioned this pull request Feb 3, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kernc kernc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misaligned Buy/Sell Markers Automatic closing of the positions at the end of the simulation
5 participants
@Benouare @mdavidg @souresia @kernc @pr0kium