Fix PyTorch stateful RNN/LSTM gradient computation error resolves #20875 #20916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #20916 +/- ##
==========================================
+ Coverage 82.22% 82.44% +0.21%
==========================================
Files 561 561
Lines 52955 53219 +264
Branches 8205 8245 +40
==========================================
+ Hits 43544 43876 +332
+ Misses 7373 7336 -37
+ Partials 2038 2007 -31
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
praveenhosdrug123
changed the title
praveenhosdrug123
force-pushed
the
fix-lstm-inplace-pytorch
branch
from
4bfd4a8 to
e0c4415
Compare
praveenhosdrug123
force-pushed
the
fix-lstm-inplace-pytorch
branch
from
e0c4415 to
48e20f6
Compare
fchollet
reviewed
Feb 27, 2025
fchollet
approved these changes
Mar 3, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
SaifMohammed22
pushed a commit
to SaifMohammed22/keras
that referenced
this pull request
Mar 6, 2025
…as-team#20875 (keras-team#20916) * Fix PyTorch stateful RNN gradient computation error * Updates post feedback
11happy
pushed a commit
to 11happy/keras
that referenced
this pull request
Mar 9, 2025
…as-team#20875 (keras-team#20916) * Fix PyTorch stateful RNN gradient computation error * Updates post feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error occurred because the PyTorch autograd engine detected that tensors required for gradient computation were modified in-place, invalidating the computational graph.
Fix: Added explicit state cloning in RNN.step() for PyTorch backend when stateful=True to create new tensor objects with separate memory allocation.