Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/retinaface similarity bugs #1141

Merged
merged 4 commits into from
Dec 4, 2023
Merged

Conversation

uranus0515
Copy link
Contributor

1,add strict infor for combineQuantize
2,change cost for resize image

Copy link

github-actions bot commented Dec 4, 2023

Test Results

5 859 tests  ±0   5 859 ✔️ ±0   7m 36s ⏱️ -31s
       6 suites ±0          0 💤 ±0 
       6 files   ±0          0 ±0 

Results for commit ecf5865. ± Comparison against base commit af51399.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (af51399) 73.25% compared to head (ecf5865) 73.23%.

Files Patch % Lines
src/Nncase.Passes/Rules/Neutral/CombineQuantize.cs 20.00% 5 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1141      +/-   ##
==========================================
- Coverage   73.25%   73.23%   -0.03%     
==========================================
  Files         707      707              
  Lines       25792    25801       +9     
  Branches     4202     4207       +5     
==========================================
+ Hits        18895    18896       +1     
- Misses       6259     6264       +5     
- Partials      638      641       +3     
Flag Coverage Δ
integration 39.11% <9.09%> (-0.01%) ⬇️
unit 65.09% <27.27%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@uranus0515 uranus0515 requested a review from xhuohai December 4, 2023 07:22
@uranus0515 uranus0515 merged commit 778d723 into master Dec 4, 2023
@uranus0515 uranus0515 deleted the fix/retinaface_similarity_bugs branch December 4, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants