Skip to content

feat(Bandcamp): Use publish date for releases before Bandcamp's launch #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

phw
Copy link
Collaborator

@phw phw commented Feb 21, 2025

If the Bandcamp release date is from before the launch of Bandcamp in September 2008 than use the separately provided publish date instead.

See #82. This matches the behavior of the Bandcamp importer user script, see https://github.com/murdos/musicbrainz-userscripts/blob/master/bandcamp_importer.user.js#L60-L73

@phw phw requested a review from kellnerd February 21, 2025 12:23
@phw phw force-pushed the bandcamp-publish-date branch from 21aa006 to b6a1013 Compare February 21, 2025 12:24
Copy link
Owner

@kellnerd kellnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
One day we will hopefully make use of the launchDate property for every provider using a generic solution which shows warnings and/or discards implausible dates.

@kellnerd kellnerd added feature New feature or request Bandcamp labels Feb 21, 2025
@kellnerd kellnerd merged commit b6a1013 into kellnerd:main Feb 21, 2025
2 checks passed
@phw phw deleted the bandcamp-publish-date branch March 20, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bandcamp feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants