feat: add bootloader hash to ProgramInfo
#52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solved two issues:
Layout Bridge
program. Piltover was using theLayout Bridge
program hash. This PR addresses that by adding the bootloader program hash to theProgramInfo
.Layout Bridge
program wasn't verified (onlySNOS
was), which could have cause any bootloaded program to be accepted by Piltover. There is now an explicit check of theLayout Bridge
program hash extracted from theprogram_output
.This PR makes also easier to debug Piltover execution when the fact is not found for the given parameters, which previously panicked with
Index out of bounds
.