Fix: Adding favicon to Kedro Demo

[jitu5]

Description

Resolves #1471

Added favicon on the demo website: https://demo.kedro.org/

Checklist

• Read the contributing guidelines
• Opened this PR as a 'Draft Pull Request' if it is work-in-progress
• Updated the documentation to reflect the code changes
• Added new entries to the RELEASE.md file
• Added tests to cover my changes

[jitu5]

@rashidakanchwala @ravi-kumar-pilla Below approach also works by creating separate end point for favicon. Please let me know which one fits as per our best practices.

 # Serve the favicon.ico file from the "html" directory
 @app.get('/favicon.ico', include_in_schema=False)
 async def favicon():
     return FileResponse(_HTML_DIR / "favicon.ico")

[rashidakanchwala]

Actually, I like both these approaches.

I did find the second approach of creating an endpoint as the most common way of serving favicon on FastAPi when I did some research yesterday.

[ravi-kumar-pilla]

Tested on GitPod and looks good to me. Can you please update the release doc before merging ? Thank you

[rashidakanchwala]

We don't need this pytest.fixture. We can use client which is defined in conftest.py and just do this directly

 def test_favicon_endpoint(self, client):
        response = client.get("/favicon.ico")
        assert response.status_code == 200
        assert response.headers["content-type"] in [
            "image/x-icon",
            "image/vnd.microsoft.icon",
        ]

Look at line 11,12 in the same file. And let me know if you have more questions.

[rashidakanchwala]

QQ - we have 2 content-types here, is it because of linux and windows tests?

[jitu5]

Here 'image/x-icon' is commonly used MIME type for ICO files, some server configurations might use 'image/vnd.microsoft.icon' as ICO files content type, in fact our test setup uses 'image/vnd.microsoft.icon' as ICO files content type. So added both content type for checks.

[rashidakanchwala]

LGTM! and congrats on your first python PR!!