Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ merge viz starters #266

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat/ merge viz starters #266

wants to merge 4 commits into from

Conversation

Huongg
Copy link

@Huongg Huongg commented Feb 25, 2025

Motivation and Context

Fixes part of #263.

As part of merging spaceflights-pandas-viz with spaceflights-pandas and spaceflights-pyspark-viz with spaceflights-pyspark, this PR aims to:

  • Update the existing spaceflights-pandas and spaceflights-pyspark to have the similar setup from viz
  • Ensure reporting is included into spaceflights-pandas and spaceflights-pyspark.
  • This PR does not remove spaceflights-pandas-viz and spaceflights-pyspark-viz immediately, as we need to verify that no major issues arise after removing the Viz tool from Kedro. Once this PR is merged and the Viz tool is fully removed from the Kedro framework, the final step will be to delete spaceflights-pandas-viz and spaceflights-pyspark-viz entirely.

How has this been tested?

Checklist

  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Assigned myself to the PR
  • Added tests to cover my changes

Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@Huongg Huongg self-assigned this Feb 25, 2025
Huong Nguyen added 3 commits February 25, 2025 13:36
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
Signed-off-by: Huong Nguyen <huong.nguyen@mckinsey.com>
@Huongg Huongg marked this pull request as draft February 25, 2025 14:36
@Huongg Huongg marked this pull request as ready for review February 25, 2025 15:27
@Huongg Huongg requested review from merelcht and ankatiyar February 25, 2025 15:27
@Huongg Huongg changed the title update catalog.yml and include reporting feat/ merge viz starters Feb 25, 2025
Copy link
Contributor

@ankatiyar ankatiyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants