Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(error): fix warnings by 'cargo clippy' for error #1002

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

octonawish-akcodes
Copy link
Contributor

@octonawish-akcodes octonawish-akcodes commented Jan 24, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

issue #191

2. What is the scope of this PR (e.g. component or file name):

KCLVM/error

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@octonawish-akcodes
Copy link
Contributor Author

Is there any IRC channel like slack or something? @Peefy

@coveralls
Copy link
Collaborator

coveralls commented Jan 24, 2024

Pull Request Test Coverage Report for Build 7640132043

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-15.4%) to 72.349%

Totals Coverage Status
Change from base Build 7639497799: -15.4%
Covered Lines: 43729
Relevant Lines: 60442

💛 - Coveralls

@octonawish-akcodes
Copy link
Contributor Author

Dont merge it yet, there is an issue in the commit.

@octonawish-akcodes octonawish-akcodes changed the title refactor(driver): fix warnings by 'cargo clippy' for driver refactor(error): fix warnings by 'cargo clippy' for error Jan 24, 2024
Signed-off-by: Abhishek Kumar <abhishek22512@gmail.com>
@octonawish-akcodes
Copy link
Contributor Author

fixed.

@Peefy
Copy link
Contributor

Peefy commented Jan 24, 2024

Is there any IRC channel like slack or something? @Peefy

See https://github.com/kcl-lang/community to join our slack. Welcome!

@Peefy Peefy merged commit 6147b90 into kcl-lang:main Jan 24, 2024
10 of 11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants