Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RABBIT_URL behavior #75

Closed
lunaqdm opened this issue Apr 5, 2018 · 2 comments
Closed

RABBIT_URL behavior #75

lunaqdm opened this issue Apr 5, 2018 · 2 comments

Comments

@lunaqdm
Copy link

lunaqdm commented Apr 5, 2018

The logic around the 'RABBIT_URL' flag assumes that all URLs will start with a prefix matching https?://. When I did not include this prefix (i.e., was doing internal routing and did not bother to set the protocol), the exporter silently set the URL to be the default http://localhost:15672. There are plenty of use cases like mine, where the protocol prefix is unnecessary; whether or not you want to keep this behavior, it would be nice to have some kind of error message generated and also some documentation.

Thanks!

kbudde added a commit that referenced this issue Apr 8, 2018
@kbudde
Copy link
Owner

kbudde commented Apr 8, 2018

Hi,

I've added an error during startup and a note in the readme for the moment.

What url are you using for your usecase?
//rabbitserver:15672

I'll see if I can add it.

@lunaqdm
Copy link
Author

lunaqdm commented Apr 9, 2018

The URL I'm using is of the form rabbitmq.<company-specific-stuff>.io, which is typical of how we set up internal routing. I was able to make it work by throwing an 'http://' on the front -- so it is nice to have the note in the readme, thanks.

@kbudde kbudde closed this as completed Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants