Make all limits configurable #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FinleyMcIlwaine
force-pushed
the
finley/make-rates-configurable
branch
2 times, most recently
from
89f6bbb to
e052497
Compare
FinleyMcIlwaine
force-pushed
the
finley/make-rates-configurable
branch
from
e052497 to
6d63e6a
Compare
|
@kazu-yamamoto We increased the rate limit for pings from 4 to 10 in #108, but we're still seeing some (Java) clients that are exceeding this for some reason. We're also seeing the empty data frames limit being hit. After this PR we can just change these defaults our side, so that's fine, but mentioning it here just in case you feel you want to increase the defaults in |
kazu-yamamoto
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all rate limits configurable