Hprint to support multiline #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: db0f33f | Previous: f1817ef | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
11396.037369961745 iter/sec (stddev: 0.000005492381212936135) |
16220.82380705509 iter/sec (stddev: 0.000004745181478990068) |
1.42 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
501.8647663653485 iter/sec (stddev: 0.0004034452187332608) |
658.0067928010251 iter/sec (stddev: 0.000015144318063940167) |
1.31 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.599309001788885 iter/sec (stddev: 0.0044321346978752115) |
11.192137930497616 iter/sec (stddev: 0.0026773551044494506) |
0.96 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
65.58907339033011 iter/sec (stddev: 0.004057015893958999) |
65.6359632569883 iter/sec (stddev: 0.003778095714932547) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
22112.812938362444 iter/sec (stddev: 0.000008343082203779212) |
22265.714585286358 iter/sec (stddev: 0.0000037441304081841704) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1702.3187539135615 iter/sec (stddev: 0.000006861834915568939) |
1778.5159014042765 iter/sec (stddev: 0.000009281271477289997) |
1.04 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
109.56039870582408 iter/sec (stddev: 0.004414296585817852) |
109.1553814192327 iter/sec (stddev: 0.004303859588069793) |
1.00 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
89.86560298023849 iter/sec (stddev: 0.003439041195332516) |
87.29051993747598 iter/sec (stddev: 0.004193673047547773) |
0.97 |
This comment was automatically generated by workflow using github-action-benchmark.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This also affects hyield_tree, hprint_tree and tree.hshow(). Note that by default strip=True for backwards compatibility, compared to strip=False in vprint, and also by default the root node will have a "prefix"
Testing
Added tests similar to vprint_tree
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)