Refactoring for export to stdout #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: 64ca6ea | Previous: 00c326c | Ratio |
|---|---|---|---|
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 |
12105.416387330975 iter/sec (stddev: 0.00004043498204301276) |
13726.119982815411 iter/sec (stddev: 0.000026328413890587953) |
1.13 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 |
628.6221009008209 iter/sec (stddev: 0.000008056279687687299) |
676.1969412772996 iter/sec (stddev: 0.00002568013839321511) |
1.08 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 |
11.05531910432914 iter/sec (stddev: 0.003890069326425072) |
11.112607565714331 iter/sec (stddev: 0.0012603852398416094) |
1.01 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 |
64.88155682024012 iter/sec (stddev: 0.002897015563281243) |
69.43627772557072 iter/sec (stddev: 0.0030625891415808535) |
1.07 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions |
21532.164209978902 iter/sec (stddev: 9.712111626732872e-7) |
22144.323413402075 iter/sec (stddev: 0.000002012708741695035) |
1.03 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions |
1669.1613674293271 iter/sec (stddev: 0.00003573385331887947) |
1697.9593500049123 iter/sec (stddev: 0.000033651423849322305) |
1.02 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions |
115.97033986657233 iter/sec (stddev: 0.00376738863334529) |
126.20499503847806 iter/sec (stddev: 0.002757013370355466) |
1.09 |
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions |
90.48385544978302 iter/sec (stddev: 0.003511580098035559) |
98.64701476080683 iter/sec (stddev: 0.002493750373940828) |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Deduplicate code by shifting common logic into the constants class
Testing
Additional notes
Checklist
I have read through the contributing guidelines and ensured that
Checklist (for reviewer)