Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to pillow graph #345

Merged
merged 7 commits into from
Feb 9, 2025
Merged

Export to pillow graph #345

merged 7 commits into from
Feb 9, 2025

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Feb 9, 2025

Description

Other enhancements due to this

  • Reingold Tilford algorithm able to 'reverse' such that coordinates go from top to bottom

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the enhancement New feature or request label Feb 9, 2025
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 7baa741 Previous: 20cfee5 Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 15329.264946438789 iter/sec (stddev: 0.000015640636314274915) 15127.07117965228 iter/sec (stddev: 0.000018478467959128297) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 672.6534618515711 iter/sec (stddev: 0.000032963903924607456) 312.7910325063218 iter/sec (stddev: 0.0023688079998169225) 0.47
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 11.500369364838127 iter/sec (stddev: 0.002569385202261596) 11.720984067637637 iter/sec (stddev: 0.000009654341016771078) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 68.71867643815999 iter/sec (stddev: 0.0029301209592756806) 67.49334609255058 iter/sec (stddev: 0.0033522189477852124) 0.98
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 22297.165472754543 iter/sec (stddev: 0.000001861741443730141) 22546.262111555556 iter/sec (stddev: 0.0000026621863209465725) 1.01
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1695.1301622649366 iter/sec (stddev: 0.00003262109855786523) 1722.3768007548533 iter/sec (stddev: 0.000008088806601308324) 1.02
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 127.51517872147927 iter/sec (stddev: 0.0026760312591322024) 118.18066119315952 iter/sec (stddev: 0.0032391008839678594) 0.93
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 97.5325160973228 iter/sec (stddev: 0.002399848431877478) 94.09458834970616 iter/sec (stddev: 0.003083829922182395) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan enabled auto-merge (squash) February 9, 2025 10:32
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.tree.construct 100% 100% 0
bigtree.tree.export 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2541 / 2543) 100% (1039 / 1040) 0

@kayjan kayjan merged commit e730142 into master Feb 9, 2025
6 checks passed
@kayjan kayjan deleted the feature/export-pillow-graph branch February 9, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant