Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split export and construct module #342

Merged
merged 12 commits into from
Feb 8, 2025
Merged

Split export and construct module #342

merged 12 commits into from
Feb 8, 2025

Conversation

kayjan
Copy link
Owner

@kayjan kayjan commented Feb 8, 2025

Description

Will be backwards compatible, behaves like a regular module but under-the-hood it is a separated into multiple files

Testing

Additional notes

Checklist

I have read through the contributing guidelines and ensured that

  • I have added a descriptive title for this pull request.
  • I have followed the convention and standards, and my code is checked for style and correctness.
  • I have added test cases, and unit tests pass with 100% code coverage.
  • I have updated the documentation and code docstrings.

Checklist (for reviewer)

  • I have added label (breaking / enhancement / bug / documentation) to this pull request, if applicable.
  • I will ensure this change is captured in the CHANGELOG.md file.

@kayjan kayjan added the enhancement New feature or request label Feb 8, 2025
Copy link
Contributor

github-actions bot commented Feb 8, 2025

Code Coverage

Package Line Rate Branch Rate Complexity Health
bigtree 100% 100% 0
bigtree.binarytree 100% 100% 0
bigtree.dag 100% 100% 0
bigtree.node 100% 100% 0
bigtree.tree 100% 100% 0
bigtree.tree.construct 100% 100% 0
bigtree.tree.export 100% 100% 0
bigtree.utils 100% 100% 0
Summary 100% (2481 / 2481) 100% (1022 / 1022) 0

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d78ab63 Previous: f4ad581 Ratio
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10 14576.398915229434 iter/sec (stddev: 0.000017064678659907702) 14724.374435039568 iter/sec (stddev: 0.000018123571066683466) 1.01
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100 303.80957458912326 iter/sec (stddev: 0.0025616965473874605) 300.0997336450138 iter/sec (stddev: 0.0026200933144663024) 0.99
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000 11.663511989924794 iter/sec (stddev: 0.0012098448533662187) 11.663331164865506 iter/sec (stddev: 0.00004113020943152467) 1.00
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10 67.76264270918483 iter/sec (stddev: 0.0031210463662882095) 64.95689994390095 iter/sec (stddev: 0.004139073938857091) 0.96
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_10_no_assertions 22192.656671892168 iter/sec (stddev: 0.000002276954546837418) 22785.53118767537 iter/sec (stddev: 0.00000820215581942095) 1.03
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_100_no_assertions 1793.1563649390387 iter/sec (stddev: 0.000007481684718488563) 1751.064778719629 iter/sec (stddev: 0.000002165585226871055) 0.98
tests/node/test_node_benchmark.py::test_node_benchmark_width_1_depth_1000_no_assertions 126.33397066085489 iter/sec (stddev: 0.00270172865093331) 113.67073224060093 iter/sec (stddev: 0.00398330927511886) 0.90
tests/node/test_node_benchmark.py::test_node_benchmark_width_2_depth_10_no_assertions 98.78146884338562 iter/sec (stddev: 0.002424423291662267) 91.18576052647406 iter/sec (stddev: 0.0035621585268544066) 0.92

This comment was automatically generated by workflow using github-action-benchmark.

@kayjan kayjan merged commit aa86906 into master Feb 8, 2025
6 checks passed
@kayjan kayjan deleted the split-module branch February 8, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant