Skip to content
This repository has been archived by the owner on Mar 13, 2024. It is now read-only.

update jest editor version #103

Merged
merged 1 commit into from
Jan 5, 2021
Merged

update jest editor version #103

merged 1 commit into from
Jan 5, 2021

Conversation

botsman
Copy link

@botsman botsman commented Dec 23, 2020

It is said that the the latest version handles parametrised tests properly.
As far as I can see by my tests, it does not fixes the problem in #26 out of the box. But since I've already updated it, decided to make a PR.

@TheSench
Copy link

The latest version definitely has better handling, although I believe it still has issues with a few edge-cases (e.g. it.only.each). That said, there's still work needed in this repo as well to allow it to run parameterized tests directly and display them in the results. I have a working PoC of that work that I will be cleaning up and turning into a PR in the near future.

@botsman
Copy link
Author

botsman commented Dec 25, 2020

The latest version definitely has better handling, although I believe it still has issues with a few edge-cases (e.g. it.only.each). That said, there's still work needed in this repo as well to allow it to run parameterized tests directly and display them in the results. I have a working PoC of that work that I will be cleaning up and turning into a PR in the near future.

Sounds awesome!
Looking forward to seeing your improvements!
Do you have any estimates on finishing your solution?

@TheSench
Copy link

The latest version definitely has better handling, although I believe it still has issues with a few edge-cases (e.g. it.only.each). That said, there's still work needed in this repo as well to allow it to run parameterized tests directly and display them in the results. I have a working PoC of that work that I will be cleaning up and turning into a PR in the near future.

Sounds awesome!
Looking forward to seeing your improvements!
Do you have any estimates on finishing your solution?

I should have a PR up by New Year's.

@TheSench
Copy link

TheSench commented Jan 5, 2021

The latest version definitely has better handling, although I believe it still has issues with a few edge-cases (e.g. it.only.each). That said, there's still work needed in this repo as well to allow it to run parameterized tests directly and display them in the results. I have a working PoC of that work that I will be cleaning up and turning into a PR in the near future.

Sounds awesome!
Looking forward to seeing your improvements!
Do you have any estimates on finishing your solution?

I don't have my PR ready, but my PoC of the changes can be found here:
https://github.com/kavod-io/vscode-jest-test-adapter/compare/master...TheSench:feature/poc-running-parameterized-tests?expand=1

This also is impacted by issue #178 in the vscode-test-explorer and a couple issues in the jest-editor-support dependency that I'm looking into.

@rossknudsen rossknudsen merged commit 2f57443 into kavod-io:master Jan 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants