Skip to content
This repository was archived by the owner on Jun 28, 2024. It is now read-only.

guest-component depds: Install clang and devmapper libs #5751

Merged
merged 1 commit into from
Aug 23, 2023
Merged

guest-component depds: Install clang and devmapper libs #5751

merged 1 commit into from
Aug 23, 2023

Conversation

surajssd
Copy link
Contributor

Fixes: #5750

@katacontainersbot katacontainersbot added the size/small Small and simple task label Aug 18, 2023
@surajssd surajssd mentioned this pull request Aug 18, 2023
Merged
@surajssd surajssd force-pushed the add-devmapper-lib branch 3 times, most recently from 5424aca to 83ae10e Compare August 18, 2023 20:26
jepio
jepio approved these changes Aug 21, 2023
View reviewed changes
Copy link
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jepio
Copy link
Member

jepio commented Aug 21, 2023

/test

@stevenhorsman
Copy link
Member

/test-tdx

ChengyuZhu6
ChengyuZhu6 reviewed Aug 21, 2023
View reviewed changes
Copy link
Member

@ChengyuZhu6 ChengyuZhu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surajssd The host system of tdx-ci is CentOS Stream 8. Maybe you can support to install dependencies on Centos?

@katacontainersbot katacontainersbot added size/medium Average sized task and removed size/small Small and simple task labels Aug 21, 2023
@stevenhorsman
Copy link
Member

/test

@ChengyuZhu6
Copy link
Member

@surajssd I have tested your pr to add sudo on centos. it's passed. So you can add sudo when installing dependencies on centos.

@katacontainersbot katacontainersbot added size/tiny Smallest and simplest task and removed size/medium Average sized task labels Aug 22, 2023
@surajssd
Copy link
Contributor Author

@ChengyuZhu6 done!

@ChengyuZhu6
Copy link
Member

@surajssd Suggest a minor change to filename install-guest-component-dependencies.sh to install_guest_component_dependencies.sh.

@surajssd
build: Install guest-component deps
c26fd38 
clang & devmapper libs

Fixes: kata-containers#5750

Signed-off-by: Suraj Deshmukh <suraj.deshmukh@microsoft.com>
@surajssd
Copy link
Contributor Author

@ChengyuZhu6 done!

@stevenhorsman
Copy link
Member

/test-tdx

@stevenhorsman
Copy link
Member

/test-fedora

@stevenhorsman
Copy link
Member

It looks like the SEV tests are passing, but the cleanup is failing:

24:48 [cleanup_env.sh:55] INFO: Check no kata processes are left behind after reseting kubernetes
19:24:49 [cleanup_env.sh:58] INFO: Checks that pods were not left
19:24:49 29dd8f064abdf5e8a96795b4bc4bb28dd52865e62ca05d610d4acfd670d4d986
19:24:49 39974e076c5f442f454793acee0cb833a00c09d925deb974d1fcfadc10ea6a67
19:24:49 67c858f98457a319a90a3f02374dcc408fd4331ef3e1f0f308f4e289fb19866b
19:24:49 ERROR: 3 pods left and found at /run/vc/sbs

@stevenhorsman
Copy link
Member

@ChengyuZhu6 - do you have permission to check the TDX logs and see what's going wrong here, or do we need to ask Arron, or Fabiano?

@jepio
Copy link
Member

jepio commented Aug 22, 2023

It looks like the SEV tests are passing, but the cleanup is failing:

24:48 [cleanup_env.sh:55] INFO: Check no kata processes are left behind after reseting kubernetes
19:24:49 [cleanup_env.sh:58] INFO: Checks that pods were not left
19:24:49 29dd8f064abdf5e8a96795b4bc4bb28dd52865e62ca05d610d4acfd670d4d986
19:24:49 39974e076c5f442f454793acee0cb833a00c09d925deb974d1fcfadc10ea6a67
19:24:49 67c858f98457a319a90a3f02374dcc408fd4331ef3e1f0f308f4e289fb19866b
19:24:49 ERROR: 3 pods left and found at /run/vc/sbs

Steve you missed this:

11:41:01 not ok 3 [cc][kubernetes][containerd][sev] Test SEV encrypted container launch success with NO measurement
11:41:01 # (from function `kubernetes_wait_for_pod_ready_state' in file lib.sh, line 42,
11:41:01 #  in test file confidential/sev.bats, line 193)
11:41:01 #   `kubernetes_wait_for_pod_ready_state "$pod_name" 20' failed
11:41:01 # Deleting previous test services...
11:41:01 # ls: cannot access '/tmp/test-kata-sev.AfCznY7h/*.yaml': No such file or directory
11:41:01 # mysql: [Warning] Using a password on the command line interface can be insecure.
11:41:01 # mysql: [Warning] Using a password on the command line interface can be insecure.
11:41:01 # service/sev-encrypted unchanged
11:41:01 # deployment.apps/sev-encrypted unchanged
11:41:01 # error: timed out waiting for the condition on pods/sev-encrypted-dd9f8bbb9-tqf54

@stevenhorsman
Copy link
Member

It looks like the SEV tests are passing, but the cleanup is failing:

24:48 [cleanup_env.sh:55] INFO: Check no kata processes are left behind after reseting kubernetes
19:24:49 [cleanup_env.sh:58] INFO: Checks that pods were not left
19:24:49 29dd8f064abdf5e8a96795b4bc4bb28dd52865e62ca05d610d4acfd670d4d986
19:24:49 39974e076c5f442f454793acee0cb833a00c09d925deb974d1fcfadc10ea6a67
19:24:49 67c858f98457a319a90a3f02374dcc408fd4331ef3e1f0f308f4e289fb19866b
19:24:49 ERROR: 3 pods left and found at /run/vc/sbs

Steve you missed this:

11:41:01 not ok 3 [cc][kubernetes][containerd][sev] Test SEV encrypted container launch success with NO measurement
11:41:01 # (from function `kubernetes_wait_for_pod_ready_state' in file lib.sh, line 42,
11:41:01 #  in test file confidential/sev.bats, line 193)
11:41:01 #   `kubernetes_wait_for_pod_ready_state "$pod_name" 20' failed
11:41:01 # Deleting previous test services...
11:41:01 # ls: cannot access '/tmp/test-kata-sev.AfCznY7h/*.yaml': No such file or directory
11:41:01 # mysql: [Warning] Using a password on the command line interface can be insecure.
11:41:01 # mysql: [Warning] Using a password on the command line interface can be insecure.
11:41:01 # service/sev-encrypted unchanged
11:41:01 # deployment.apps/sev-encrypted unchanged
11:41:01 # error: timed out waiting for the condition on pods/sev-encrypted-dd9f8bbb9-tqf54

Yeah, sorry - I looked at multiple runs I re-queued. test 3 (which is still a known flake?) failed on one of them, but passed on the other two (http://jenkins.katacontainers.io/job/tests-CCv0-ubuntu-20.04_sev-x86_64-CC_SEV_CRI_CONTAINERD_K8S-PR/524/consoleFull is the one I copied the content from), so I don't think this is causing that. Sorry for the lack of clarity!

@ChengyuZhu6
Copy link
Member

@ChengyuZhu6 - do you have permission to check the TDX logs and see what's going wrong here, or do we need to ask Arron, or Fabiano?

Let me take a look.

@ChengyuZhu6
Copy link
Member

The reason tdx-qemu test failed was network timed out:

18:06:17 error: failed to download from `[https://crates.io/api/v1/crates/prost-build/0.8.0/download`](https://crates.io/api/v1/crates/prost-build/0.8.0/download%60)
18:06:48 
18:06:48 Caused by:
18:06:48   [28] Timeout was reached (download of `prost-build v0.8.0` failed to transfer more than 10 bytes in 30s)

The reason tdx-clh test failed was build timed out of containerd :

Build timed out (after 20 minutes). Marking the build as aborted.
13:30:29 /root/clean_qemu_check2.sh: line 10: 1548640 Terminated              sleep 1
13:50:28 .ci/install_cri_containerd.sh: line 56: 1547163 Terminated              curl -OL -f "${url}"
13:50:28 Failed to download tarball from https://github.com/confidential-containers/containerd/releases/download/v1.6.8.2/cri-containerd-cni-1.6.8.2-linux-amd64.tar.gz

Sorry for that. I have retest these two tests.

@ChengyuZhu6
Copy link
Member

tdx cloud hypervisor passed but it seems it was not updated here: http://10.112.240.228:8080/job/tests-CCv0-cloud-hypervisor-TDX-CRI_CONTAINERD_K8S-PR/592

ChengyuZhu6
ChengyuZhu6 approved these changes Aug 22, 2023
View reviewed changes
Copy link
Member

@ChengyuZhu6 ChengyuZhu6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @surajssd !

@stevenhorsman
Copy link
Member

Fourth time lucky on re-queing the SEV tests \o/. We're just waiting for SNP tests now, which seem to have issues on with the node on Jenkins, which I've raised in #kata-ci, so hopefully will be looked at soon.

stevenhorsman
stevenhorsman approved these changes Aug 23, 2023
View reviewed changes
Copy link
Member

@stevenhorsman stevenhorsman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@jepio jepio merged commit 7f5a015 into kata-containers:CCv0 Aug 23, 2023
@surajssd surajssd deleted the add-devmapper-lib branch August 23, 2023 14:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jepio jepio jepio approved these changes

@stevenhorsman stevenhorsman stevenhorsman approved these changes

@ChengyuZhu6 ChengyuZhu6 ChengyuZhu6 approved these changes

Assignees
No one assigned
Labels
size/tiny Smallest and simplest task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@surajssd @jepio @stevenhorsman @ChengyuZhu6 @katacontainersbot