Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French Translations and fix genCalList() #11

Merged
merged 2 commits into from
Jan 23, 2015
Merged

Add French Translations and fix genCalList() #11

merged 2 commits into from
Jan 23, 2015

Conversation

lherry
Copy link
Contributor

@lherry lherry commented Jan 23, 2015

There was a problem with getCalList() when $start != 1...

There was a problem when `$start` != 1...
@lherry lherry changed the title Fix $start use problem Fix $start use problem on getCalList() Jan 23, 2015
Added french messages definitions
@lherry
Copy link
Contributor Author

lherry commented Jan 23, 2015

The pull request includes the update of french messages definitions

@lherry
Copy link
Contributor Author

lherry commented Jan 23, 2015

Yes you are right, but if you try to use your dayList() method with $start = 2, we will have days in bad order... no ?

@kartik-v
Copy link
Owner

No the days will start from Monday if you set start to 2. Check the example again.

@lherry
Copy link
Contributor Author

lherry commented Jan 23, 2015

Yes it starts by Monday, but after we have Sunday and next Saturday... which is reversed, no ?
Normally, we should have : Monday, Tuesday, Wednesday...

@kartik-v
Copy link
Owner

Check the example for dayList in the demo and see if you can test and understand.

@lherry
Copy link
Contributor Author

lherry commented Jan 23, 2015

Ok, but I've got an Error (#1) : An internal server error occurred.
Corrected (empty cache, sorry...)
I'll tell you ! :)

@kartik-v
Copy link
Owner

Refresh the page and retry.

@lherry
Copy link
Contributor Author

lherry commented Jan 23, 2015

Result of your given test :

print_r(Enum::dayList(false, 2));

Array ( [1] => Lundi [2] => Dimanche [3] => Samedi [4] => Vendredi [5] => Jeudi [6] => Mercredi [7] => Mardi )

I'm waiting for something like this :

Array ( [1] => Lundi [2] => Mardi [3] => Mercredi [4] => Jeudi [5] => Vendredi [6] => Samedi [7] => Dimanche )

@kartik-v kartik-v closed this Jan 23, 2015
@kartik-v kartik-v reopened this Jan 23, 2015
@kartik-v
Copy link
Owner

Let me recheck on this and get back.

@kartik-v
Copy link
Owner

Thanks for the update. Merging this.

kartik-v added a commit that referenced this pull request Jan 23, 2015
Add French Translations and fix genCalList
@kartik-v kartik-v merged commit 8177880 into kartik-v:master Jan 23, 2015
@kartik-v kartik-v changed the title Fix $start use problem on getCalList() Add French Translations and fix genCalList() Jan 23, 2015
@kartik-v
Copy link
Owner

It would be good if you can complete all the French translations for benefit of others.

@lherry
Copy link
Contributor Author

lherry commented Jan 23, 2015

You're welcome ! Thanks to give us usefull extensions !
Of course for translating, I've done all I know but there are some words which don't need to be translated (app names, models,...), or they are equivalent from us to fr (would you like that I add the matching to show that it is explicitely translated ?)...
So I'll add plural's definitions and, to me, except if I missed something else, all is done !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants