feat: add k.cancel() #545
Merged
feat: add k.cancel() #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
niceEli
approved these changes
Nov 28, 2024
lajbel
requested changes
Nov 28, 2024
src/types.ts
Outdated
Comment on lines
5512
to
5524
| /** | ||
| * Cancels the event if returned. | ||
| * | ||
| * @since v3001.1 | ||
| * @group Events | ||
| * @example | ||
| * ```js | ||
| * onKeyPress((key) => { | ||
| * if (key === "q") return k.cancel(); | ||
| * }); | ||
| * ``` | ||
| */ | ||
| cancel: () => Symbol, |
There was a problem hiding this comment.
Use the correct format described in Contributing.md
lajbel
approved these changes
Nov 29, 2024
lajbel
pushed a commit
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for
k.cancel(), a new way to cancel events in KAPLAY. As discussed on Discord,k.cancelis a method (when it could just be a property) to signify that it has an "action", to maybe help beginners better understand it.