Skip to content

feat: normalize get/set methods for camera, add getLayers and getDefaultLayer #532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2024
Merged

feat: normalize get/set methods for camera, add getLayers and getDefaultLayer #532

merged 1 commit into from
Nov 23, 2024

Conversation

lajbel
Copy link
Member

@lajbel lajbel commented Nov 23, 2024

  • Added getLayers() to get the layers list
  • Added getDefaulLayer() to get the default layer
  • Deprecated camera methods camScale(), camPos() and camRot() in favor of
    setCamScale(), getCamScale(), setCamPos(), getCamPos(), setCamRot()
    and getCamRot.
  • Deprecated camFlash() in favor of flash(), for a shake()-like name.
  • Deprecated camTransform() in favor of getCamTransform().

@lajbel lajbel changed the title chore: set/get methods feat: set/get methods Nov 23, 2024
@lajbel lajbel changed the title feat: set/get methods feat: normalize get/set methods for camera, add getLayers and getDefaultLayer Nov 23, 2024
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 23, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/kaplayjs/kaplay@532

commit: 0f7e653

@lajbel lajbel requested a review from mflerackers November 23, 2024 01:16
@lajbel lajbel merged commit 4fe02fd into master Nov 23, 2024
3 checks passed
lajbel pushed a commit that referenced this pull request Nov 23, 2024
@lajbel
feat: normalize get/set methods for camera, add getLayers and getDefa…
05aedf4 
…ultLayer (#532)
@lajbel lajbel deleted the get-set-camera branch March 12, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflerackers mflerackers mflerackers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
KAPLAY.js Features
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lajbel @mflerackers