refactor: context in 1 variable #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
mflerackers
approved these changes
Nov 8, 2024
mflerackers
reviewed
Nov 14, 2024
| @@ -20,17 +20,17 @@ export function opacity(a: number): OpacityComp { | |||
| return { | |||
| id: "opacity", | |||
| opacity: a ?? 1, | |||
| fadeIn(time = 1, easeFunc = k.easings.linear): TweenController { | |||
| return game.root.tween( | |||
| fadeIn(time = 1, easeFunc = _k.k.easings.linear): TweenController { | |||
There was a problem hiding this comment.
yep, _k also contains the k handler
|
|
||
| export function dt() { | ||
| return app.dt() * debug.timeScale; |
There was a problem hiding this comment.
debug.timeScale is no longer needed?
There was a problem hiding this comment.
no because app.dt() already did it, it was dupplied
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues or related