Skip to content

add onLoadError #501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 13, 2024
Merged

add onLoadError #501

merged 5 commits into from
Nov 13, 2024

Conversation

dragoncoder047
Copy link
Contributor

gives authors the option to bluescreen the whole game if assets fail to load

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Nov 8, 2024 •
edited
Loading

Open in Stackblitz

pnpm add https://pkg.pr.new/kaplayjs/kaplay@501

commit: a3c42af

@niceEli niceEli requested a review from mflerackers November 11, 2024 15:38
lajbel
lajbel approved these changes Nov 13, 2024
View reviewed changes
Copy link
Member

@lajbel lajbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very good, high quality

@lajbel lajbel merged commit 913c20a into kaplayjs:master Nov 13, 2024
2 checks passed
lajbel pushed a commit that referenced this pull request Nov 23, 2024
@dragoncoder047 @lajbel
add onLoadError (#501)
7f6ae4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mflerackers mflerackers mflerackers approved these changes

@lajbel lajbel lajbel approved these changes

@niceEli niceEli niceEli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
KAPLAY.js Features
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dragoncoder047 @mflerackers @lajbel @niceEli