Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): support ref-tags with default values #13

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tests: added missing cases to tests
MatteoVoges committed Mar 27, 2023
commit 2fa70145d4f4dc6328759e718acd6e8ca2bddfed
14 changes: 14 additions & 0 deletions reclass/datatypes/tests/test_parameters.py
Original file line number Diff line number Diff line change
@@ -414,6 +414,20 @@ def test_nested_deep_references(self):
p.interpolate()
self.assertEqual(p.as_dict(), r)

def test_nested_references_default_exists(self):
values = {"a": "value", "b": "${not:existing||${a}}"}
reference = {"a": "value", "b": "value"}
parameters = Parameters(values, SETTINGS, '')
parameters.interpolate()
self.assertEqual(parameters.as_dict(), reference)

def test_nested_references_default_exists(self):
values = {"a": "value", "b": "${not:existing||${again||fallback}}"}
reference = {"a": "value", "b": "fallback"}
parameters = Parameters(values, SETTINGS, '')
parameters.interpolate()
self.assertEqual(parameters.as_dict(), reference)

def test_stray_occurrence_overwrites_during_interpolation(self):
p1 = Parameters({'r' : 1, 'b': '${r}'}, SETTINGS, '')
p2 = Parameters({'b' : 2}, SETTINGS, '')
5 changes: 5 additions & 0 deletions reclass/values/tests/test_refitem.py
Original file line number Diff line number Diff line change
@@ -49,6 +49,11 @@ def test_default_resolve_ok(self):
result = reference._resolve('non:existing||default', {'foo':'bar'})
self.assertEquals(result, 'default')

def test_default_exists_resolve_ok(self):
reference = RefItem('', Settings({'delimiter': ':'}))
result = reference._resolve('foo||default', {'foo':'bar'})
self.assertEquals(result, 'bar')

def test__resolve_fails(self):
refitem = RefItem('', Settings({'delimiter': ':'}))
context = {'foo':{'bar': 1}}