Feat/fix bug #144
Merged
Feat/fix bug #144
+75
−52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to the
adbpadproject, focusing on improving the functionality and user interface for screenshot commands, as well as updating string resources and simplifying the codebase.Screenshot functionality improvements:
selectCommandandonSelectCommandparameters to theScreenshotScreenandScreenshotDropDownButtoncomponents to allow users to select a screenshot command. (src/jvmMain/kotlin/jp/kaleidot725/adbpad/Main.kt[1] [2];src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/screenshot/ScreenshotScreen.kt[3] [4] [5] [6];src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/screenshot/component/ScreenshotDropDownButton.kt[7] [8]ScreenshotStateandScreenshotStateHolderto include the selected command and handle the newSelectScreenshotCommandaction. (src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/screenshot/ScreenshotState.kt[1];src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/screenshot/ScreenshotStateHolder.kt[2] [3] [4] [5]String resources updates:
StringResourcesfor various languages by removing the native script from the names. (src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/language/resources/ChineseResources.kt[1];src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/language/resources/EnglishResources.kt[2];src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/language/resources/JapaneseResources.kt[3];src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/language/resources/TurkishResources.kt[4]Codebase simplification:
isRunningproperty fromScreenshotCommandand converted the command classes todata objectfor simplicity. (src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/command/ScreenshotCommand.ktsrc/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/command/ScreenshotCommand.ktL7-R20)clearmethod and therunningCommandsset fromScreenshotCommandRepositoryImplas they were no longer needed. (src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/repository/ScreenshotCommandRepository.kt[1];src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/usecase/refresh/RefreshUseCase.kt[2];src/jvmMain/kotlin/jp/kaleidot725/adbpad/repository/impl/ScreenshotCommandRepositoryImpl.kt[3] [4] [5] [6] [7] [8]Version update:
v2.0.0tov2.0.1. (src/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/language/resources/StringResources.ktsrc/jvmMain/kotlin/jp/kaleidot725/adbpad/domain/model/language/resources/StringResources.ktL3-R3)