Refactor screens #143
Merged
Refactor screens #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the state management and UI components in the
adbpadproject. The most important changes include the introduction of new actions and side effects for theCommandandSettingscreens, the addition of a newDefaultOutlineTextFieldcomponent, and the refactoring of state holders to use the MVI pattern.State Management Improvements:
src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/command/CommandAction.kt: Added newCommandActionsealed class to handle command-related actions.src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/command/CommandStateHolder.kt: RefactoredCommandStateHolderto use the MVI pattern and handle actions more effectively.src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/setting/SettingAction.kt: Added newSettingActionsealed class to handle setting-related actions.UI Component Enhancements:
src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/component/DefaultOutlineTextField.kt: Added newDefaultOutlineTextFieldcomponent to provide a customizable outlined text field.src/jvmMain/kotlin/jp/kaleidot725/adbpad/Main.kt: UpdatedAppfunction to use new actions and effects for command and setting screens. [1] [2]Miscellaneous Improvements:
src/jvmMain/kotlin/jp/kaleidot725/adbpad/core/mvi/MVIDelegate.kt: UpdatedMVIDelegateto cancel coroutine scope on dispose.src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/command/CommandState.kt: ImplementedMVIStateinterface inCommandState.src/jvmMain/kotlin/jp/kaleidot725/adbpad/ui/screen/screenshot/ScreenshotStateHolder.kt: Removed unnecessary coroutine scope cancellation inScreenshotStateHolder.