Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugfix command category #139

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

kaleidot725
Copy link
Owner

This pull request introduces a new ALL category to the NormalCommandCategory enum and updates the codebase to use this new category instead of null for filtering commands. The most important changes include modifying the CommandScreen, CommandState, and CommandTab components to accommodate this new category.

Enum Update:

  • Added ALL to the NormalCommandCategory enum in NormalCommandCategory.kt.

Command Screen Updates:

  • Changed the filtered parameter in CommandScreen to use NormalCommandCategory.ALL instead of null. [1] [2] [3]

Command State Updates:

  • Updated CommandState to use NormalCommandCategory.ALL as the default value for the filtered property.
  • Modified CommandStateHolder to initialize the filtered state with NormalCommandCategory.ALL and updated the clickTab method accordingly. [1] [2]

Command Tab Updates:

  • Adjusted CommandTab to handle NormalCommandCategory.ALL instead of null. [1] [2]

@kaleidot725 kaleidot725 merged commit 1ccd847 into main Feb 17, 2025
2 checks passed
@kaleidot725 kaleidot725 deleted the fix/bugfix_command_category branch February 17, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant