Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Windows/ChineseLanguage/Actions Add auto packageExe #104

Merged
merged 8 commits into from
Dec 28, 2024

Conversation

crowforkotlin
Copy link
Contributor

@crowforkotlin crowforkotlin commented Nov 26, 2024

Tip

I removed “jSystemThemeDetectorVer” library because I think it is unnecessary! Sacrificing the option of packaging Windows programs for an adaptive system theme. If you don't delete this library, you will not be able to package on Windows. jSystemThemeDetectorVer depends on jna. When running on Windows, it will prompt Could not find jna-5.14.0-jpms.jar! I tried to introduce this dependency from the library and search for solutions on Google, but it didn't work! And after deleting this dependency, it runs normally

  • Added chinese language

  • Added pointer location

  • Added layout bounds

  • Added automatic packaging of release and debug windows executable program workflow

  • Set the default theme light

  • Support windows

  • Remove unnecessary libraries “jSystemThemeDetectorVer”

@crowforkotlin crowforkotlin mentioned this pull request Nov 26, 2024
@crowforkotlin
Copy link
Contributor Author

@kaleidot725 kaleidot725 changed the base branch from develop to develop_1.3.0 December 28, 2024 03:31
Copy link
Owner

@kaleidot725 kaleidot725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kaleidot725
Copy link
Owner

@crowforkotlin

Thanks for the fixes. I will merge the detailed implementation, although I am sure we will fix it here,

Sorry for the delay, I saw your email, I was aware of the error around jlink, I don't think there is a workaround if you are using JBR, so I would like to modify this one to not use JBR.

#106

@kaleidot725 kaleidot725 merged commit be95ad5 into kaleidot725:develop_1.3.0 Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants