Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for the OTEL prometheus meter exporter, prometheus exporter server and auto reloads on code changes #2075

Merged
merged 7 commits into from
Mar 11, 2025

Conversation

kalaspuff
Copy link
Owner

  • Fixes an issue where the OTEL prometheus meter provider would start the prometheus exporter server although the service was not instrumented if an OTEL meter was created outside of the service' auto instrumentation scope. On hot reloads of code changes this would also cause the prometheus exporter server to be started multiple times, causing the service to fail to restart due to a port conflict.
  • Fixes an issue in OTEL prometheus exporter target info where the service_name and job could be incorrectly set to "unknown_service" if an OTEL meter was created before the service was fully initialized and instrumented.
  • Added jwcrypto to the list of safe modules that won't be cleared during the hot auto reload on code changes.
  • Restricted version constraint of OTEL API / OTEL SDK to 1.27.0 until support for exemplar builder is fully implemented into tomodachi's aggregators.

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes missing coverage. Please review.

Project coverage is 73.91%. Comparing base (ebadd2e) to head (50ac0ca).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
tomodachi/opentelemetry/prometheus.py 37.50% 10 Missing ⚠️
tomodachi/opentelemetry/middleware.py 60.00% 4 Missing ⚠️
tomodachi/transport/amqp.py 0.00% 1 Missing ⚠️
tomodachi/transport/http.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (44.82%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2075      +/-   ##
==========================================
- Coverage   73.98%   73.91%   -0.07%     
==========================================
  Files          53       53              
  Lines        8095     8112      +17     
==========================================
+ Hits         5989     5996       +7     
- Misses       2106     2116      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kalaspuff kalaspuff merged commit 2886647 into master Mar 11, 2025
13 of 14 checks passed
@kalaspuff kalaspuff deleted the feature/otel-safe-modules branch March 11, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant