fix(admin): fix snwatcher handle heartbeat timeout #1070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hungryjang
force-pushed
the
fix-snwatcher-handle-heartbeat-timeout
branch
from
9e54fd2 to
8c3a241
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
- Coverage 79.71% 79.35% -0.37%
==========================================
Files 178 178
Lines 21564 21637 +73
==========================================
- Hits 17190 17170 -20
- Misses 3591 3674 +83
- Partials 783 793 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ijsong
reviewed
Apr 4, 2025
This change fixes an issue where not all expected logstreams could be sealed within HandleHeartbeatTimeout due to storagenode delaying the response. Also fixes an issue where unexpected logstreams were being sealed by heartbeat false positives. In particular, it increases the priority of seal requests for metarepos so that commit results in metarepos do not pile up even if sealing is delayed.
hungryjang
force-pushed
the
fix-snwatcher-handle-heartbeat-timeout
branch
from
8c3a241 to
ba419aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Which issue(s) this PR resolves
This change fixes an issue where not all expected logstreams could be sealed within HandleHeartbeatTimeout due to storagenode delaying the response. Also fixes an issue where unexpected logstreams were being sealed by heartbeat false positives. In particular, it increases the priority of seal requests for metarepos so that commit results in metarepos do not pile up even if sealing is delayed.
Resolves #1068 #1069
Anything else
Include any links or documentation that might be helpful for reviewers.