Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(admin): add TestAdmin_Storagenode_HeartbeatTimeout_Seal #1066

Merged
merged 2 commits into from
Apr 4, 2025

Conversation

hungryjang
Copy link
Member

This test verifies whether the expected logstreams are sealed when storagenode timeout occurs.

Currently it does not work as expected due to a bug. Once it is fixed, the test will need to be changed.

What this PR does

Which issue(s) this PR resolves

Resolves #

Anything else

Include any links or documentation that might be helpful for reviewers.

@hungryjang hungryjang requested a review from ijsong as a code owner April 1, 2025 01:51
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (c8f4af1) to head (93afce5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   79.59%   79.78%   +0.18%     
==========================================
  Files         178      178              
  Lines       21552    21552              
==========================================
+ Hits        17155    17195      +40     
+ Misses       3612     3583      -29     
+ Partials      785      774      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@hungryjang hungryjang force-pushed the test_snwatcher_sn_timeout branch 2 times, most recently from 40e63a9 to c1436b9 Compare April 1, 2025 08:57
This test verifies whether the expected logstreams are sealed when
storagenode timeout occurs.

Currently it does not work as expected due to a bug. Once it is fixed,
the test will need to be changed.
@hungryjang hungryjang force-pushed the test_snwatcher_sn_timeout branch from c1436b9 to 6d100b9 Compare April 1, 2025 09:03
@hungryjang hungryjang merged commit 0f5ee2b into main Apr 4, 2025
10 checks passed
@hungryjang hungryjang deleted the test_snwatcher_sn_timeout branch April 4, 2025 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants