benchmark and improve rounding #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirlensalot
commented
Nov 16, 2019
| defTrunc n desc op = defRNative n fun (funType tTyDecimal [("x",tTyDecimal),("prec",tTyInteger)] <> | ||
| unaryTy tTyInteger tTyDecimal) | ||
| [ ExecExample $ "(" <> asString n <> " 3.5)" | ||
| , ExecExample $ "(" <> asString n <> " 100.15234 2)" | ||
| ] | ||
| (desc <> " value of decimal X as integer, or to PREC precision as decimal.") | ||
| where fun :: RNativeFun e | ||
| fun _ [TLiteral (LDecimal d) _] = return $ toTerm $ op d |
There was a problem hiding this comment.
The big surprise here is truncate . roundTo' op 0 is much, much faster (~6us) than using RealFrac methods directly on Decimal (~22us)
emilypi
approved these changes
Nov 16, 2019
| @@ -393,7 +393,7 @@ Return ID if called during current pact execution, failing if not. | |||
| Obtain current pact build version. | |||
| ```lisp | |||
| pact> (pact-version) | |||
| "3.3.0" | |||
| "3.3.1" | |||
| defTrunc n desc op = defRNative n fun (funType tTyDecimal [("x",tTyDecimal),("prec",tTyInteger)] <> | ||
| unaryTy tTyInteger tTyDecimal) | ||
| [ ExecExample $ "(" <> asString n <> " 3.5)" | ||
| , ExecExample $ "(" <> asString n <> " 100.15234 2)" | ||
| ] | ||
| (desc <> " value of decimal X as integer, or to PREC precision as decimal.") | ||
| where fun :: RNativeFun e | ||
| fun _ [TLiteral (LDecimal d) _] = return $ toTerm $ op d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #644
Huge improvement to both overloads of decimal rounding! With benchmarks. See #644 for benchmark comparisons.