Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List-modules moved to local-only #1326

Merged
merged 8 commits into from
Feb 16, 2024
Merged

List-modules moved to local-only #1326

merged 8 commits into from
Feb 16, 2024

Conversation

jmcardon
Copy link
Member

PR checklist:

  • Test coverage for the proposed changes
  • PR description contains example output from repl interaction or a snippet from unit test output
  • Documentation has been updated if new natives or FV properties have been added. To generate new documentation, issue cabal run tests. If they pass locally, docs are generated.
  • Any changes that could be relevant to users have been recorded in the changelog
  • In case of changes to the Pact trace output (pact -t), make sure pact-lsp is in sync.

Additionally, please justify why you should or should not do the following:

  • Confirm replay/back compat
  • Benchmark regressions
  • (For Kadena engineers) Run integration-tests against a Chainweb built with this version of Pact

@jwiegley
Copy link
Contributor

It will be nice to see a repl test, just to make sure it never gets re-enabled on main.

Copy link
Member

@emilypi emilypi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Echoing john here: we can simulate on-chain now so let's use it to do the regression.

@jmcardon
Copy link
Member Author

Currently having an issue with nix infra. Will merge once our haskell.nix is functioning again.

@jmcardon jmcardon merged commit 1779158 into master Feb 16, 2024
3 checks passed
enobayram added a commit to kadena-io/hs-nix-infra that referenced this pull request Feb 16, 2024
This PR bumps our Haskell toolchain in order to allow Pact to upgrade to `ghc964`. See kadena-io/pact#1326

* update haskell.nix

* update hackage input

* update nixpkgs flake input

* update haskell.nix

* Bump nixpkgs, haskellNix, hackage to latest

* Pin nixpkgs to an older version that has ghc884

* Discard new unused haskell-nix inputs

---------

Co-authored-by: chessai <chessai1996@gmail.com>
@jmcardon jmcardon deleted the jose/list-modules-local branch May 10, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants