Core: Fix return RTC flag, Events Disable flag #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsoeldner
approved these changes
Jul 8, 2024
.github/pull_request_template.md
Outdated
| @@ -2,10 +2,11 @@ PR checklist: | |||
|
|
|||
| * [ ] Test coverage for the proposed changes | |||
| * [ ] PR description contains example output from repl interaction or a snippet from unit test output | |||
| * [ ] Any changes that could be relevant to users [have been recorded in the changelog](https://github.com/kadena-io/pact-core/blob/master/CHANGELOG.md) | |||
| * [ ] (If Relevant) New builtins have a FV translation | |||
There was a problem hiding this comment.
Suggested change
| * [ ] (If Relevant) New builtins have a FV translation |
| -> EvalM e b i () | ||
| emitEvent info pe = findCallingModule >>= \case | ||
| Just mn -> do | ||
| -- Todo: ++ definitely feels suboptimal, especially for gas. |
There was a problem hiding this comment.
consider moving the comment to emitEventUnsafe, as emitEvent does not use ++.
Rename progn to do Factor out common code between CEK/Direct
Fix env-events to reverse the event order on emission Make Pact.Core.IR.Term exports qualified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename progn to do
Factor out common code between CEK/Direct
PR checklist: