Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change CassandraTaskExports filtering #554

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Change CassandraTaskExports filtering #554

merged 2 commits into from
Oct 23, 2024

Conversation

burmanm
Copy link
Contributor

@burmanm burmanm commented Oct 23, 2024 •
edited
Loading

Uses String instead of OperationType for compare

And fix CHANGELOG ordering.

Fixes #553

@burmanm burmanm requested a review from emerkle826 October 23, 2024 11:47
emerkle826
emerkle826 requested changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@emerkle826 emerkle826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of the unused import and I think things look good.

emerkle826
emerkle826 approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@emerkle826 emerkle826 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Feel free to merge when the tests run as long as there aren't consistent failures around the OperationType stuff.

@burmanm
Copy link
Contributor Author

burmanm commented Oct 23, 2024

The failed tests are just timeouts when trying to even start the test (and some of them keep hanging).

@burmanm burmanm merged commit 04c1eb9 into master Oct 23, 2024
129 of 132 checks passed
@burmanm burmanm deleted the fix_task_export_metrics-mapi-74 branch October 23, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emerkle826 emerkle826 emerkle826 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Major compaction tracking metric is broken in 5.0.2
2 participants
@burmanm @emerkle826