Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API endpoint that allows creating a Keyspace #27

Merged
merged 3 commits into from
Jul 6, 2020
Merged

Add API endpoint that allows creating a Keyspace #27

merged 3 commits into from
Jul 6, 2020

Conversation

nastra
Copy link

@nastra nastra commented Jul 2, 2020

No description provided.

@nastra nastra force-pushed the create-keyspace-api branch 2 times, most recently from 1c67a01 to 5b67ec0 Compare July 6, 2020 07:28
@nastra nastra linked an issue Jul 6, 2020 that may be closed by this pull request
Add support for creating keyspaces #26
Closed
@nastra nastra force-pushed the create-keyspace-api branch from 5b67ec0 to edaf4a0 Compare July 6, 2020 08:59
@nastra nastra force-pushed the create-keyspace-api branch from edaf4a0 to 2d289d8 Compare July 6, 2020 09:49
@nastra nastra requested a review from tjake July 6, 2020 10:03
tjake
tjake suggested changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@tjake tjake left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the operator also needs an alter keyspace replication for when it brings up a new DC.

@nastra
Copy link
Author

nastra commented Jul 6, 2020

I think the operator also needs an alter keyspace replication for when it brings up a new DC.

@tjake np I can add that. Maybe as a separate issue/PR?

tjake
tjake approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@tjake tjake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 with Alter in new PR

@nastra nastra merged commit e26ca4a into master Jul 6, 2020
@nastra nastra deleted the create-keyspace-api branch July 6, 2020 14:48
jimdickinson
jimdickinson reviewed Jul 7, 2020
View reviewed changes
Copy link
Contributor

@jimdickinson jimdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great - thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimdickinson jimdickinson jimdickinson left review comments

@RazakDangi RazakDangi RazakDangi left review comments

@tjake tjake tjake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for creating keyspaces
4 participants
@nastra @tjake @jimdickinson @RazakDangi