Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDB-34 Added Docker files and scripts to make the management API work… #15

Merged
merged 1 commit into from
May 21, 2020

Conversation

sbtourist
Copy link
Contributor

… with Astra-flavoured OSS distributions.

Copy link

@stef1927 stef1927 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK as far as I can see, but perhaps either @tjake or @jimdickinson should also take a look.

@@ -0,0 +1,105 @@
FROM adoptopenjdk:8-jre-hotspot-bionic
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stef1927 FYI I've amended this back to a jre image, same as the upstream OSS one (while I previously switched to a jdk image for a test).

@sbtourist
Copy link
Contributor Author

Thanks @stef1927. @tjake and/or @jimdickinson, any interest in reviewing this?

@tjake
Copy link
Contributor

tjake commented May 20, 2020

Do you want to publish this to docker as well if tagged?

@sbtourist
Copy link
Contributor Author

Do you want to publish this to docker as well if tagged?

@tjake It is currently tagged as 4.0, but such tag would be continuously updated as we develop it. I'm not sure that's a good practice. I'm also wondering if it makes sense to release it as "4.0" given we're soon going to diverge significantly from OSS 4.0. I'd say not to publish it until we figure things out.

@tjake tjake merged commit 1a225f9 into k8ssandra:master May 21, 2020
# fi
# done
# Set this if you want to ignore default env variables, i.e. when running inside an operator
if [ $IGNORE_DEFAULTS ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this needs to be the default way this image works for compatibility with published operator versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants