Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HintsService and ReadCoordination can return incorrect labeling #524

Closed
burmanm opened this issue Aug 23, 2024 · 1 comment · Fixed by #525
Closed

HintsService and ReadCoordination can return incorrect labeling #524

burmanm opened this issue Aug 23, 2024 · 1 comment · Fixed by #525
Assignees
@burmanm
Labels
done Issues in the state 'done'

Comments

@burmanm
Copy link
Contributor

burmanm commented Aug 23, 2024

As seen in #512 there were metrics which have the IP + port in the metricName part itself, since the formatting had

"org\\.apache\\.cassandra\\.metrics\\.\\.(\\w+)\\.(\\w+)\\.(.+)$"

instead of "org\\.apache\\.cassandra\\.metrics\\.\\.(\\w+)\\.(.+)$"

HintsService and ReadCoordination are two metrics that do not have this special case taken care of and as such return incorrect metric naming:

# TYPE org_apache_cassandra_metrics_hints_service_hint_delays_10_244_2_14_7000 summary
# TYPE org_apache_cassandra_metrics_read_coordination_replica_latency_10_244_3_15_7000 summary
@burmanm burmanm self-assigned this Aug 23, 2024
@burmanm burmanm moved this to In Progress in K8ssandra Aug 23, 2024
@adejanovski adejanovski added the in-progress Issues in the state 'in-progress' label Aug 23, 2024
@burmanm
Copy link
Contributor Author

burmanm commented Aug 26, 2024

ReadCoordination metrics are DSE/HCD only.

@burmanm burmanm mentioned this issue Aug 26, 2024
Merged
@burmanm burmanm moved this from In Progress to Ready For Review in K8ssandra Aug 26, 2024
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed in-progress Issues in the state 'in-progress' labels Aug 26, 2024
@emerkle826 emerkle826 moved this from Ready For Review to Review in K8ssandra Aug 29, 2024
@adejanovski adejanovski added review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Aug 29, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in K8ssandra Aug 29, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Aug 29, 2024
emerkle826 added a commit that referenced this issue Sep 4, 2024
@emerkle826
Release v0.1.85
d68b012 
* [FEATURE] [#523](#523) Trust store reload functionality for DSE only (not Cassandra)
* [FEATURE] [#527](#527) Add Cassandra 4.1.6 to the build matrix
* [FEATURE] [#522](#522) Add DSE 6.9.1 to the build matrix
* [FEATURE] [#529](#529) Add DSE 6.9.2 to the build matrix
* [ENHANCEMENT] [#521](#521) Add management-api to Cassandra conf in the Dockerfile, not entrypoint for DSE 6.9, Cassandra 4.1 and Cassandra 5.0. This allows to run the container with readOnlyRootFilesystem.
* [BUGFIX] [#524](#524) Fix HintsService Hint_delays- metrics parsing and ReadCoordination metrics parsing
* [BUGFIX] [#520](#520) Update DSE 6.9.0 dependnecy
* [BUGFIX] [#531](#531) Fix DSE 6.9 UBI image agent loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@burmanm burmanm

Labels
done Issues in the state 'done'
Projects
No open projects
K8ssandra
Status: Done
Milestone
No milestone
2 participants
@burmanm @adejanovski