Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove cassandra-topology.properties from the configuration folder #463

Closed
1 task
adejanovski opened this issue Mar 26, 2024 · 2 comments · Fixed by #464
Closed
1 task

Remove cassandra-topology.properties from the configuration folder #463

adejanovski opened this issue Mar 26, 2024 · 2 comments · Fixed by #464
Assignees
@emerkle826
Labels
done Issues in the state 'done'

Comments

@adejanovski
Copy link
Contributor

In order to avoid some weird and annoying bugs with the GossipPropertyFileSnitch still considering the cassandra-topology.properties file in some cases, which could cause unsafe instant topology changes, we should remove the file altogether at runtime.

Definition of Done
Preview Give feedback
@adejanovski adejanovski moved this to Ready in K8ssandra Mar 26, 2024
@adejanovski adejanovski added the ready Issues in the state 'ready' label Mar 26, 2024
@emerkle826
Copy link
Contributor

@bradfordcp @adejanovski Do we need to do this for DSE as well, or just OSS Cassandra images?

@adejanovski
Copy link
Contributor Author

I'd say both. We don't want this file anywhere.

@emerkle826 emerkle826 mentioned this issue Mar 27, 2024
Merged
@emerkle826 emerkle826 moved this from Ready to Ready For Review in K8ssandra Mar 27, 2024
@emerkle826 emerkle826 self-assigned this Mar 27, 2024
@adejanovski adejanovski added ready-for-review Issues in the state 'ready-for-review' and removed ready Issues in the state 'ready' labels Mar 27, 2024
@adejanovski adejanovski moved this from Ready For Review to Review in K8ssandra Mar 29, 2024
@adejanovski adejanovski added review Issues in the state 'review' and removed ready-for-review Issues in the state 'ready-for-review' labels Mar 29, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in K8ssandra Apr 2, 2024
@adejanovski adejanovski added done Issues in the state 'done' and removed review Issues in the state 'review' labels Apr 2, 2024
emerkle826 added a commit that referenced this issue Apr 25, 2024
@emerkle826
Release v0.1.75
c8ed75b 
* [FEATURE] [#474](#474) Add DSE 6.8.46 to the build matrix
* [FEATURE] [#461](#461) Add Cassandra 5.0-beta1 tot he build matrix
* [FEATURE] [#470](#470) Add Cassandra 4.0.12 to the build matrix
* [FEATURE] [#467](#467) Add DSE 6.8.44 to the build matrix
* [FEATURE] [#469](#469) Add Cassandra 3.11.17 to the build matrix
* [ENHANCEMENT] [#465](#465) Add tar to the DSE images
* [BUGFIX] [#463](#463) Remove cassandra-topology.properties from the configuration folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerkle826 emerkle826

Labels
done Issues in the state 'done'
Projects
No open projects
K8ssandra
Archived in project
Milestone
No milestone
2 participants
@emerkle826 @adejanovski