fix: reverse hpa ScalingLimited error condition

[antoinedeschenes]

Closes #

📑 Description

k8sgpt currently outputs - Error: the desired count is within the acceptable range when an HPA is working properly. This is due to the "ScalingLimited" condition to be reversed:

      message: the desired count is within the acceptable range
      reason: DesiredWithinRange
      status: "False"
      type: ScalingLimited

This also fixes a typo in the analyzer's name not matching the kind, although that could be removed for another time.

✅ Checks

• My pull request adheres to the code style of this project
• My code requires changes to the documentation
• I have updated the documentation as required
• All the tests have passed

ℹ Additional Information

[antoinedeschenes]

This would break k8sgpt filters add, maybe I should remove it?

[AlexsJones]

Are you saying because this is using v2 api it would break on default?

[antoinedeschenes]

I’m sorry, this wasn't clear. I mean that renaming the filter won’t align with the active_filters value used in an existing k8sgpt.yaml config file. This might need a config migration.

[antoinedeschenes]

@AlexsJones

Should there also be a specific case for kubernetes/kubernetes#116387

[AlexsJones]

Need to figure out if this needs us to update the config

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.23%. Comparing base (173e4dc) to head (03adcfc).
Report is 55 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   34.76%   34.23%   -0.54%     
==========================================
  Files          94       97       +3     
  Lines        6342     6511     +169     
==========================================
+ Hits         2205     2229      +24     
- Misses       4046     4189     +143     
- Partials       91       93       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.